Add security fixes: SHA256 hash validation and streaming file size enforcement
- Add field_validator to ResumableUploadInitRequest to validate expected_hash is a valid 64-character lowercase hex SHA256 hash (normalizes to lowercase) - Add FileSizeExceededError exception for file size limit violations - Enforce file size limits in storage layer during streaming (prevents Content-Length header spoofing) - Add FileSizeExceededError handler in upload endpoint returning HTTP 413 - Add node_modules and frontend/dist to .gitignore
This commit is contained in:
@@ -176,6 +176,12 @@ class HashComputationError(StorageError):
|
||||
pass
|
||||
|
||||
|
||||
class FileSizeExceededError(StorageError):
|
||||
"""Raised when file exceeds maximum size during upload"""
|
||||
|
||||
pass
|
||||
|
||||
|
||||
class S3ExistenceCheckError(StorageError):
|
||||
"""Raised when S3 existence check fails after retries"""
|
||||
|
||||
@@ -261,6 +267,7 @@ class S3Storage:
|
||||
|
||||
Raises:
|
||||
HashComputationError: If hash computation fails
|
||||
FileSizeExceededError: If file exceeds maximum size
|
||||
S3ExistenceCheckError: If S3 existence check fails after retries
|
||||
S3UploadError: If S3 upload fails
|
||||
"""
|
||||
@@ -270,11 +277,18 @@ class S3Storage:
|
||||
if not content:
|
||||
raise HashComputationError("Empty file content")
|
||||
|
||||
size = len(content)
|
||||
|
||||
# Enforce file size limit (protection against Content-Length spoofing)
|
||||
if size > settings.max_file_size:
|
||||
raise FileSizeExceededError(
|
||||
f"File size {size} exceeds maximum {settings.max_file_size}"
|
||||
)
|
||||
|
||||
sha256_hash = hashlib.sha256(content).hexdigest()
|
||||
md5_hash = hashlib.md5(content).hexdigest()
|
||||
sha1_hash = hashlib.sha1(content).hexdigest()
|
||||
size = len(content)
|
||||
except HashComputationError:
|
||||
except (HashComputationError, FileSizeExceededError):
|
||||
raise
|
||||
except Exception as e:
|
||||
logger.error(f"Hash computation failed: {e}")
|
||||
@@ -349,6 +363,7 @@ class S3Storage:
|
||||
|
||||
Raises:
|
||||
HashComputationError: If hash computation fails
|
||||
FileSizeExceededError: If file exceeds maximum size
|
||||
S3ExistenceCheckError: If S3 existence check fails after retries
|
||||
S3UploadError: If S3 upload fails
|
||||
"""
|
||||
@@ -369,13 +384,19 @@ class S3Storage:
|
||||
sha1_hasher.update(chunk)
|
||||
size += len(chunk)
|
||||
|
||||
# Enforce file size limit during streaming (protection against spoofing)
|
||||
if size > settings.max_file_size:
|
||||
raise FileSizeExceededError(
|
||||
f"File size exceeds maximum {settings.max_file_size}"
|
||||
)
|
||||
|
||||
if size == 0:
|
||||
raise HashComputationError("Empty file content")
|
||||
|
||||
sha256_hash = sha256_hasher.hexdigest()
|
||||
md5_hash = md5_hasher.hexdigest()
|
||||
sha1_hash = sha1_hasher.hexdigest()
|
||||
except HashComputationError:
|
||||
except (HashComputationError, FileSizeExceededError):
|
||||
raise
|
||||
except Exception as e:
|
||||
logger.error(f"Hash computation failed for multipart upload: {e}")
|
||||
|
||||
Reference in New Issue
Block a user